php-cache / issues

Issue Tracker for PHP-Cache
http://www.php-cache.com
8 stars 4 forks source link

Logging Documentation in Cache bundle allows level configuration #122

Open lnesi opened 6 years ago

lnesi commented 6 years ago

At http://www.php-cache.com/en/latest/symfony/cache-bundle/#logging

The level properties is not implemented at:

https://github.com/php-cache/cache-bundle/blob/b0b54bbe4f7fbd23f0dcf5eb53c6f1d4a605a702/src/DependencyInjection/Configuration.php#L141-L154

    private function addLoggingSection()
    {
        $tree = new TreeBuilder();
        $node = $tree->root('logging');

        $node
            ->canBeEnabled()
            ->addDefaultsIfNotSet()
            ->children()
                ->scalarNode('logger')->defaultValue('logger')->end()
            ->end();

        return $node;
    }
lnesi commented 6 years ago

Also reviewing more into details in the AnstractCachePool.php the log is only executed when exceptions happen and not to all interactions as shown on the documentation.