search

php-ds / ext-ds

An extension providing efficient data structures for PHP 7
https://medium.com/p/9dda7af674cd
MIT License
2.11k stars 95 forks source link

Release supporting PHP 8.1 #188

Closed simPod closed 2 years ago

simPod commented 3 years ago

Hello @rtheunissen , is there anything I can do to help with releasing a new version (1.4.0?) with PHP 8.1 support?

Thanks!

rtheunissen commented 2 years ago

I'll make a new release on pecl today. :+1:

icanhazstring commented 2 years ago

@rtheunissen I am trying to install it using php-extension-installer on docker, see linked issue. Maybe it's worth noting that I am using an alpine docker base, with ubuntu-latest in github actions it seems like it's working.

Edit: local docker using php:8.1-cli (which uses ubuntu) is also not working

rtheunissen commented 2 years ago

I was having some issues locally too but I am making progress - thank you for your patience.

icanhazstring commented 2 years ago

Thanks for the effort and the feedback 👍

icanhazstring commented 2 years ago

@rtheunissen is there a way to bring in support?

rtheunissen commented 2 years ago

@icanhazstring I think I have a working build now, just running a few final tests. I haven't been close to this project in a while, took me a while to get set up again. I'm looking forward to working on it more this holiday season, close all these open issues and prepare for PHP 9.

rtheunissen commented 2 years ago

Just release 1.4.0 on PECL with PHP 8.1 support. Please verify this and close this ticket when everything looks OK.

icanhazstring commented 2 years ago

Works for my use case. Thanks 👍

solcik commented 2 years ago

Works for me too. Thank you very much!

jfcherng commented 2 years ago

Thanks for the new release on https://windows.php.net/downloads/pecl/releases/ds/1.4.0/ 👍

Any chance also have a pre-built for PHP 8.1 Windows since that's the main reason we have a new release?

simPod commented 2 years ago

Just installed stable on prod, wrks. Thanks 🎉