php-enqueue / enqueue-dev

Message Queue, Job Queue, Broadcasting, WebSockets packages for PHP, Symfony, Laravel, Magento. DEVELOPMENT REPOSITORY - provided by Forma-Pro
https://enqueue.forma-pro.com/
MIT License
2.17k stars 430 forks source link

Laravel Exceptions don't reject the message? #898

Closed saranshdhingra closed 5 years ago

saranshdhingra commented 5 years ago

I am using the laravel-enqueue extension with the transport STOMP.

Laravel Version: 5.4 Active MQ: from Amazon MQ Protocol: STOMP(with SSL)

I am able to dispatch a job and confirm that a new message is there in the ActiveMQ UI. I am also able to confirm that when I run php artisan queue:work, the message is dequeued from the broker.

But, in cases of exception, shouldn't we pass a reject message to the broker? So, that the consumer can then re-fetch the message in order to leverage the retries?

I think this is what happens in the database driver.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.