search

php-pds / skeleton

Standard PHP package skeleton.
Creative Commons Attribution Share Alike 4.0 International
2.3k stars 167 forks source link

Use a metapackage for composer #22

Closed stof closed 7 years ago

stof commented 7 years ago

As this package does not provide any code and is meant to be required as an indication of adoption, forcing all projects to download it does not make sense. Metapackages cover this case.

Revisor commented 7 years ago

Nice, I didn't know about this. For those interested, here's the documentation:
https://getcomposer.org/doc/04-schema.md#type

This is not my project, so it may be not my place to ask, but could you squash the commits, please? Two of the three are nonfunctional.

stof commented 7 years ago

This PR should be rejected if #21 is meant to be merged though, as it will then bring code.

However, I still think that using keywords rather than type to hold standard is better according to the composer schema.

pmjones commented 7 years ago

This and other future PDS publications are likely to include code of some sort, so "metapackage" seems inappropriate.

As for using keywords instead of the package type: noted, and pondering. :-)

stof commented 7 years ago

@pmjones you can change the type of package once it starts having code in it.