search

php / doc-en

English PHP documentation
496 stars 729 forks source link

Some parts of the chm manual file are in a very small font #3780

Open lkintact opened 5 days ago

lkintact commented 5 days ago

Some parts of the chm version of the manual are in a very small font, they are underlined in red in the picture below (that's at "PHP Manual -> Function reference -> Image Processing and Generation -> ImageMagick -> Installing/Configuring -> Installation"): chm_manual_small_font

OS: Windows 10 Home.

Girgias commented 5 days ago

Maybe @mumumu has an idea? As IIRC they know how to build the CHM version.

But this might be an issue with PhD our doc renderer.

jimwins commented 5 days ago

This is probably a missing style for the CHM version (which basically just a particular HTML format). Looks like it is for anything that ends up in a <var> tag, so filenames, environment variables, and other variables. I can blindly change the stylesheet for the CHM version (chm/make_chm_style.css in doc-base, I think) to see if it helps, but I don't have any Windows systems to test it on. (There's a style for 'PRE', I'd make it 'VAR, PRE' to see if that helps.)

Looks like @bjori is involved in the building of the CHM versions, they may have more insight.

bjori commented 5 days ago

Sounds like a good theory @jimwins . Give it a try and see if @lkintact can verify if it worked. I don't think I ever had first-hand experiencing using the chm builds :)

jimwins commented 5 days ago

Looking at it more, it's actually probably one of the CSS files in the htmlhelp/suppfiles directory of doc-base. But I'm not even sure how/when this gets rebuilt because the CHM files were last updated about two months ago.

It should be possible to use GitHub Actions to build these. There's a command-line HTMLHelp compiler so then it's "just" a matter of building the proper input, running that, and making the output available somewhere. That's going to require someone with more active Windows knowledge than I have, though.