Add support for `os-families-exclude` in extensions `composer.json`

php / pie

The PHP Installer for Extensions

BSD 3-Clause "New" or "Revised" License

630 stars 18 forks source link

Add support for `os-families-exclude` in extensions `composer.json` #116

Open alexandre-daubois opened 3 days ago

alexandre-daubois commented 3 days ago

Fix #106

Allows to specify OS families which the extension is incompatible with:

{
    "name": "myvendor/myext",
    "php-ext": {
        "extension-name": "myext",
        "configure-options": [
            // ...
        ],
        "os-families-exclude": ['Windows', 'Darwin']
    }
}

When the syntax is validated, I'll create a PR in Composer to allow the new key in the Package::$phpExt property.

alexandre-daubois commented 1 day ago

Revamped the whole PR to address your comments.

Things are done in ResolveDependencyWithComposer instead of CommandHelper
An enum holding OS families is added
It is added to the TargetPlatform
PhpBinaryPath is used to determine the OS family, just like the OS

tillkruss commented 14 hours ago

This is great, love to exclude windows.