php1ic / inch

The Interactive Nuclear CHart
GNU General Public License v3.0
3 stars 2 forks source link

Convert Partition::section::value to a template variable #4

Closed php1ic closed 3 years ago

php1ic commented 5 years ago

The struct Partition::section has a member Partition::section::value which is type double for 4 of 5 use cases and a string for the other. Making it a template should allow the removal of a lot of code bloat when setting isotope attributes.

php1ic commented 3 years ago

It's now 3 of the 5. Half-life is a time we use std::chrono::duration

php1ic commented 3 years ago

Actually I'm going to close this ticket, Partition::decayMap and Partition::halLifeMap have allowed us to use an algorithm to set the required attribute.

No need to make this a template.