search

php1ic / inch

The Interactive Nuclear CHart
GNU General Public License v3.0
3 stars 2 forks source link

Clean up magic numbers #9

Closed php1ic closed 3 years ago

php1ic commented 5 years ago

Not particle magic number (i.e. 2,8,20 etc)

There are a lot of magic numbers scattered throughout the code, mainly due to the formatting of the data files, e.g position of the mass-excess value in the NUBASE, or the header size for AME.

Look into either refactoring them into a single header (or enum?) or individually per file/mass database.

php1ic commented 3 years ago

This looks to be done. There might be one or two hiding somewhere, but they can be removed as they are discovered.