search

phpmyadmin / phpmyadmin

A web interface for MySQL and MariaDB
https://www.phpmyadmin.net/
GNU General Public License v2.0
7.45k stars 3.46k forks source link

Fix columns order in Table Structure #19568

Closed faissaloux closed 2 days ago

faissaloux commented 1 month ago

Fixes #19558

CommanderRoot commented 1 month ago

To follow the pattern of the other parts of the query ordinal_position should probably be upper cased and surrounded by "`" like this ORDER BY `ORDINAL_POSITION`

CommanderRoot commented 1 month ago

It probably also makes sense to add the sorting here as well to fix the order on the "Designer" https://github.com/phpmyadmin/phpmyadmin/blob/a192a5215f9fbba290e651f1eaed32d95e313278/src/Query/Generator.php#L172

faissaloux commented 1 month ago

It probably also makes sense to add the sorting here as well to fix the order on the "Designer"

I'll work on this on another PR after merging this one, thanks for mentioning it!

kamil-tekiela commented 1 week ago

Are you still working on it? The change needs to be made on line 172 too and the tests need to be updated.

faissaloux commented 1 week ago

Are you still working on it? The change needs to be made on line 172 too and the tests need to be updated.

Yeah I'm on it, just got busy. I'll fix the Designer columns order too and the tests as soon as I find some time for it.

faissaloux commented 3 days ago

@MauricioFauth done!