search

phpmyadmin / themes

Third party phpMyAdmin themes
https://www.phpmyadmin.net/themes/
200 stars 154 forks source link

Theme darkwolf for phpMyAdmin 5.2 #82

Closed SteppenWolf68 closed 1 year ago

SteppenWolf68 commented 2 years ago

I would add the verification of this theme and have the possibility that it can be downloaded from https://www.phpmyadmin.net/themes/

Thank you very much

darkwolfbootstrap.zip

williamdes commented 2 years ago

I am thinking about re-working our theme process to only have to upload scss files and a CI job would build the CSS files By the way, do you use and edit scss files? And also write some indications for users to be able to test and write new themes

SteppenWolf68 commented 2 years ago

Hi @williamdes ....Thanks for answering.

I've edited a bit of SCSS, I'm not very familiar with it, but I think it's just a matter of studying to expand knowledge. We have to be updated as much as possible or we will be stuck. In addition, all the work you do is always to improve and we must adapt and learn hand in hand with you.

williamdes commented 2 years ago

Hi @williamdes ....Thanks for answering.

I've edited a bit of SCSS, I'm not very familiar with it, but I think it's just a matter of studying to expand knowledge. We have to be updated as much as possible or we will be stuck. In addition, all the work you do is always to improve and we must adapt and learn hand in hand with you.

Just to be sure: do you want to update your darkwolf theme or create a new one ?

williamdes commented 2 years ago

Hi @williamdes ....Thanks for answering.

I've edited a bit of SCSS, I'm not very familiar with it, but I think it's just a matter of studying to expand knowledge. We have to be updated as much as possible or we will be stuck. In addition, all the work you do is always to improve and we must adapt and learn hand in hand with you.

Thank you for your patience ! I just added documentation, let me know how it works for you: https://github.com/phpmyadmin/themes#how-to-contribute

SteppenWolf68 commented 2 years ago

I consider that updating the theme is the best, I hope that most of you will keep updated phpMyAdmin to the most recent version so that it works well, since from now on I will only update darkwolf for the bootstrap theme. I really appreciate your help and patience with me.

williamdes commented 2 years ago

I consider that updating the theme is the best, I hope that most of you will keep updated phpMyAdmin to the most recent version so that it works well, since from now on I will only update darkwolf for the bootstrap theme. I really appreciate your help and patience with me.

Okay, so I will proceed to renaming to darkwolf in some of the next updates of this PR

SteppenWolf68 commented 2 years ago

The theme looks good and has no files that require license information. That said, I would ask two questions:

  • Can this theme be rebuilt from its scss files (my tests show no)?
  • Did you modify the file directly?.css

Yes, I modified the file directly from the .css

In future updates I will do it directly from .scss

williamdes commented 2 years ago

Okay, I think we can then update the theme and wait for your scss updates :) Do you need some help compiling scss ?

SteppenWolf68 commented 2 years ago

Did you also modify darkwolf/css/theme.rtl.css ?

That's right, I also modified theme.rtl.css

SteppenWolf68 commented 2 years ago

Okay, I think we can then update the theme and wait for your scss updates :) Do you need some help compiling scss ?

For this darkwolfbootstrap theme, I would greatly appreciate your help in the scss compilation, for future versions or updates of the theme I would be doing it myself. Really thank you very much for all your help. Cheers

ibennetch commented 1 year ago

I've uploaded this and it's now available at https://web.phpmyadmin.net/themes/#pma_5_2.

Many thanks for your contribution!