search

phpro / zf-doctrine-hydration-module

Configurable Doctrine hydrators for ZF2
18 stars 33 forks source link

Php53 #15

Closed TomHAnderson closed 9 years ago

TomHAnderson commented 9 years ago

Per #14 this gives backwards compatibility to PHP 5.3.

Two commits here, the second one I need your eye for. PHP 5.3 does not support ReflectionInstance::newInstanceWithoutConstructor. 5.3 unit tests pass with my change but I don't know all the consequences of this change. Could we do the same thing with https://github.com/Ocramius/Instantiator ?

veewee commented 9 years ago

I would definitly go for doctrine/instantiator instead of using newInstance. Entities can have constructor parameters, so this code will fail on entities with constructor parameters.

TomHAnderson commented 9 years ago

I think this PR is done.