search

phpro / zf-doctrine-hydration-module

Configurable Doctrine hydrators for ZF2
18 stars 33 forks source link

by_value option not respected #22

Open Bilge opened 8 years ago

Bilge commented 8 years ago

Regardless of the by_value setting, AbstractMongoStrategy::hydrateCollection always attaches AllowRemoveByValue strategy. When by_value is false it should attach AllowRemoveByReference instead.

veewee commented 8 years ago

The hydration of the object still respects the by_value configuration. The strategy is something that is configured to extract / hydrate a property. So the strategy does not NEED to respect the hydrator. It is something stand-alone that is attached to the hydrator.

I agree that in an ideal situation you could choose between the strategy base class. However this won't be an easy fix. It is also not a good idea to create duplicate strategies just to respect the by_value configuration of the main hydrator. We will propably have to think this one through.