search

phpro / zf-doctrine-hydration-module

Configurable Doctrine hydrators for ZF2
18 stars 33 forks source link

ZF3 Compatibility #35

Closed michalbundyra closed 7 years ago

michalbundyra commented 8 years ago

Added support for ZF3 modules. Only PHP5.6 and PHP7.0 are supported. Depends on:

veewee commented 8 years ago

Hi @webimpress,

Thanks for the PR, it looks pretty good! The only thing I am worried about is the amount of non official modules and it's versions:

"api-skeletons/zf-doctrine-module-zend-hydrator": "^1.0",
"doctrine/doctrine-module": "dev-feature/zf3compat as 1.0",
"doctrine/doctrine-orm-module": "dev-feature/zf3compat",
"doctrine/doctrine-mongo-odm-module": "dev-feature/zf3compat",

Do you have any idea on what's the state on ZF3 compatibility in the doctrine modules? As long as those projects aren't ZF3 compatible, it might be better to wait until the features are merged in the officiel repo?

michalbundyra commented 7 years ago

ping @veewee

All dependencies are now tagged. Please release when you have a moment. Thanks!

michalbundyra commented 7 years ago

@veewee thanks for review, please have a look on my fixes.

veewee commented 7 years ago

@webimpress: released in 3.0.0: https://github.com/phpro/zf-doctrine-hydration-module/releases/tag/v3.0.0

michalbundyra commented 7 years ago

@veewee thanks !