search

phpspec / prophecy

Highly opinionated mocking framework for PHP 5.3+
MIT License
8.53k stars 241 forks source link

PHPUnit 10 compatibility, master is compatible but not the v1.17.0 tag… #599

Closed shulard closed 10 months ago

shulard commented 1 year ago

Hello !

I work on a project where we are using both PHPUnit and PHPSpec. I can't upgrade to PHPUnit 10 because there is a conflict with the latest stable version of phpspec/prophecy which requires sebastian/recursion-context v4.

I viewed that the master branch is up to date and allows installing PHPUnit 10, do you think it might be possible to create a new release ? Is there some instability today on master that might block the release process ?

If so I can try to help fixing those issues… Let me know :smile:

alexander-schranz commented 1 year ago

Not a maintainer of this project but think at current case the best until it is released is what we can do, is to test if the current master versions works as expected by trying it out in our projects and give feedback if we stumble over some issues. For this you can currently use the @dev versions:

    "require-dev": {
        "phpspec/prophecy": "^1.18@dev",
        "phpspec/prophecy-phpunit": "^2.1@dev",
        "phpunit/phpunit": "^10.2"
    }

For paratest user also update to:

        "brianium/paratest": "^7.0",

is required. In my case with a project about ~1800 Unit Tests using prophecy all did work fine.

keradus commented 1 year ago

@stof , I think it was you releasing last time. You think a new release of what is already merged is possible?

rikgirbes commented 10 months ago

Any updates on this? I really dislike using @dev's in my composer.json...

jg-development commented 10 months ago

+1

jorgsowa commented 10 months ago

Hello @stof. Do you need any help releasing a new version?

stof commented 10 months ago

1.18.0 has been released now

keradus commented 10 months ago

thanks @stof !

Unfortunately, I failed to install it because this one is not yet compatible (yet having v10 PR already merged, simply not released): https://github.com/phpspec/prophecy-phpunit