search

phptal / PHPTAL

PHP Template Attribute Language — template engine for XSS-proof well-formed XHTML and HTML5 pages
http://phptal.org
GNU Lesser General Public License v2.1
175 stars 43 forks source link

PHP 7.3 compatibility and testing #68

Closed Ocramius closed 5 years ago

Ocramius commented 5 years ago

Fixes #64

Rebases #64 and introduces CI entries for PHP 5.6~7.3

Ocramius commented 5 years ago

@Potherca @shivashanti @jacekkarczmarczyk @monojp can I ask you to glance over this? If it looks good, I'll go ahead and tag 1.4.0, create 1.4.x and merge into master afterwards.

tanakahisateru commented 5 years ago 
    "version":"1.3.1",

can't be removed?

Ocramius commented 5 years ago

@tanakahisateru I didn't clean up code in this patch - don't have time for it right now, and what's more pressing is the support for newer releases. Anyone willing to take on the endeavor of improving the code quality of PHPTAL is welcome to do so with further patches (better if we target 2.0 for those though)

Ocramius commented 5 years ago

Right, shipping this, but will not merge to 1.3.x: 1.4.x will be started, and I'll tag from there.

1.3.x is only for security issues from now on.