search

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.83k stars 200 forks source link

Release 0.1.5 to PECL #29

Closed cscott closed 10 years ago

cscott commented 11 years ago

It would be nice to have a released version with the time/memory limits!

satoshi75nakamoto commented 11 years ago

Hey @cscott — I'll try to do this later this weekend or next week. Thanks for the nudge.

satoshi75nakamoto commented 11 years ago

@cscott — Take a look at: http://git.php.net/?p=pecl/languages/v8js.git and let me know what you think.

— Patrick

stesie commented 11 years ago

Hey @preillyme

the Git repo looks good to me, very cool that there will be a release soon :-)

However the tar.gz from http://pecl.php.net/get/v8js-0.1.4.tgz is broken, i.e. FTBFS since the v8js_commonjs.cc is missing. Besides the tests and samples are missing.

cheers stesie

satoshi75nakamoto commented 10 years ago

@stesie — I've created http://pecl.php.net/package/v8js/0.1.5 now that should fix those issues.

cscott commented 10 years ago

Looks good to me, although I can't test it easily since debian's libv8 is still too old. Seems to work fine when I'm building outside of PECL, though.

satoshi75nakamoto commented 10 years ago

@cscott — Thanks for testing.

stesie commented 10 years ago

+1

works for me as well