search

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.83k stars 200 forks source link

Test V8::executeString() : Check timezone handling fail #368

Closed gempir closed 6 years ago

gempir commented 6 years ago

I'm running into an issue with V8JS. I've compiled V8 from scratch with the latest release. As described here: https://github.com/phpv8/v8js/blob/php7/README.Linux.md

Since I'm on Debian Stretch I followed the instructions with patchelf too.

Then I compiled V8JS it. And Ran the tests. Test V8::executeString() : Check timezone handling [tests/timezones.phpt]

This test failed. I'm not sure why.

I've been running this on a local vagrant machine on my mac with High Sierra if that's relevant.

Unsetting the default.timzone in my php.ini did not help Setting the path to the icudtl.dat in the php.ini didn't help either. Although it shouldn't be necessary anyway since it's next to the libv8.so in /opt/v8/lib

Here is some of the test summary: 

=====================================================================
TEST RESULT SUMMARY
---------------------------------------------------------------------
Exts skipped    :    0
Exts tested     :   16
---------------------------------------------------------------------

Number of tests :  173               172
Tests skipped   :    1 (  0.6%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    1 (  0.6%) (  0.6%)
Expected fail   :    0 (  0.0%) (  0.0%)
Tests passed    :  171 ( 98.8%) ( 99.4%)
---------------------------------------------------------------------
Time taken      :   10 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Test V8::executeString() : Check timezone handling [tests/timezones.phpt]
=====================================================================

================================================================================
/tmp/v8js/tests/timezones.phpt
================================================================================
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
===EOF===
================================================================================
001+ Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
002+ Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
003+ Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
001- Thu Mar 20 2014 11:03:24 GMT+0200 (EET)
002- Thu Mar 20 2014 05:03:24 GMT-0400 (EDT)
003- Thu Mar 20 2014 11:03:24 GMT+0200 (EET)
================================================================================

================================================================================
BUILD ENVIRONMENT
================================================================================
OS:
Linux - Linux dev.moebel-vergleich.de 4.9.0-7-amd64 #1 SMP Debian 4.9.110-1 (2018-07-05) x86_64

System Information: Debian Stretch Kernel: 4.9.0-7-amd64 V8: 6.9.454 and 6.4.388.18 (tried both) PHP: PHP 7.1.19 V8JS Version: Latest master (commit: 18b79d90046a63209cedf58ef24e2f4f0281f7a1) also tried 2.0.0

UPDATE

I just repeated this with a completly different system. Based on Debian Jessie (And not Vagrant). I'm getting the exact same error.

gempir commented 6 years ago

I recompiled 6.5.143 of V8 which makes v8js tests work! Not Sure whats the issue with newer versions?

Edit: I'll close this issue now since I have no more issues (the previous issue i noted here was related to an import of babel-polyfill)