search

phpv8 / v8js

V8 Javascript Engine for PHP — This PHP extension embeds the Google V8 Javascript Engine
http://pecl.php.net/package/v8js
MIT License
1.83k stars 200 forks source link

Travis config doesn't check for test suite errors #56

Closed stesie closed 10 years ago

stesie commented 10 years ago

The Travis configuration doesn't seem to check for test suite errors correctly.

See build output of https://travis-ci.org/stesie/v8js/builds/12743962 (I'm currently preparing another pull request, which broke the PHP 5.3 build however)

[...]
=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
Test V8::executeString() : Initialized properties on derived class [tests/derived_class_properties_init.phpt]
=====================================================================
make[1]: Leaving directory `/home/travis/build/stesie/v8js'
The command "make -f Makefile.travis test" exited with 0.
Done. Your build exited with 0.

... and the build is marked with state "passed".

stesie commented 10 years ago

This is related to https://bugs.php.net/bug.php?id=60285, which is fixed in 5.5 branch

Hence the auto-build against 5.3 by travis won't fail even if REPORT_EXIT_STATUS=1 would be set in the environment

cscott commented 10 years ago

I've got a fix for this (see above) but it makes travis always fail, since we've got a bunch of leaks right now and travis php machines are configured with leak checking. So it's probably best to wait to merge this until we get the leak situation a bit more under control.

cscott commented 10 years ago

Fix landed with pull request #70.