Shared variables lost when cache enabled

[Illvili]

Hello,

I encountered an issue with the following code:

<?php
use Pug\Pug;

include 'vendor/autoload.php';

$pug = new Pug([
    'shared_variables' => [
        'foo' => 123
    ],
    'cache' => __DIR__ . '/cache'
]);

$pug->display('p=foo');

I expected to get:

<p>123</p>

But I actually get:

<p></p>

So I found something here: Phug\Renderer\Partial\AdapterTrait line 94

$adapter->displayCached($path, $input, $getSource, $parameters);

change it to:

$adapter->displayCached($path, $input, $getSource, $this->mergeWithSharedVariables($parameters));

could solve this.

Does this change cause someting error?

Additional, at first I try to use Phug with js style expression, when cache enable it fail with

You cannot use "cache_dir" option with Phug\Renderer\Adapter\EvalAdapter because this adapter does not implement Phug\Renderer\CacheInterface

Thanks!

[kylekatarnls]

Hello,

Indeed $parameters should always be used with mergeWithSharedVariables before a rendering. I will fix it.

Can you give me the PHP code of your second error (with Phug)?

[kylekatarnls]

You second problem should now also be fixed by updating with composer update

[Illvili]

Every thing work fine, thanks!