Open mhussaincov opened 4 years ago
an update, it seembs that total requests for 24 hours are displayed but in a way that it is not accessible to screen readers sigh would it be possible to make that accessible like the bit where total requests for all clients is displayed? I hope this makes sence,
sorry finger slipped when submitting
This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.
Adding Bug
to this so that it's not going to be stale again. I think accessible issues should not auto-closed, but needs active closing by affected people after an issue is solved.
This seems to be most easily fixed by adding a variable to the API (in /stats/summary for v6) called "allowed" or something. Then it should be easy to just add the extra code to add it to the GUI. Otherwise doing some quick math subtracting the blocked queries from the total queries.
Might be a good candidate for v6?
The problem here isn't really how to get the number. It is more one of presentation. The UI uses bootstrap which allows for 12 "logical" columns. At this point, there are four counters at the top, spread evenly over those 12 columns (with three each):
Adding a fifth makes it hard to distribute the space. Either one has to make the counters a different size:
Alternatives could be to split these on multiple lines, or perhaps making it a configuration option which four counters to display.
At any rate, it isn't so much how to get the data, more how to present it...
Perhaps a dumb question: What value does having the number of allowed queries add to the dashboard? For me, at least, the only figure that matters (when I even look at the web interface) is the blocked count/percentage. I can't think of any reason why I, again personally, would want to know how many queries were explicitly allowed...
No wrong responses!
I concur. This issue seems to handle two demands, while the second one got a bit lost but is why @yubiuser added the bug
tag:
it seembs that total requests for 24 hours are displayed but in a way that it is not accessible to screen readers sigh would it be possible to make that accessible like the bit where total requests for all clients is displayed? I hope this makes sence,
@mhussaincov how would you like this to happen? If we'd make this accessible and it'd start reading out 150 numbers (the bars) ... somehow I get the feeling this wouldn't be helpful a single bit and rather make the interface entirely useless. To the best of my knowledge, that's also why nothing is being spelled out here at the moment.
In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}
How familiar are you with the the source code relevant to this issue?:
{Replace this with a number from 1 to 10. 1 being not familiar, and 10 being very familiar}
1Expected behaviour:
{A detailed description of what you expect to see}
Actual behaviour:
{A detailed description and/or screenshots of what you do see}
when you load the pi-hole admin page you can see total requests and requests blocked, would it be possable for the ui to display total allowed requests?
Steps to reproduce:
{Detailed steps of how we can reproduce this}
log in to the pi-hole admin interface and you will see the total requests and blocked requests this is accessible with orca. Debug token provided by uploadingpihole -d
log:{Alphanumeric token}
Troubleshooting undertaken, and/or other relevant information:
{Steps of what you have done to fix this}