search

pianobooster / PianoBooster

A MIDI file player/game that displays the musical notes and teaches you how to play the piano.
Other
397 stars 74 forks source link

Certain middle notes are unreachable #301

Open juliusdeblaaij opened 3 years ago

juliusdeblaaij commented 3 years ago

When loading certain midi files, some notes in the middle of the keybaord are "skipped". PianoBosster recognizes the keypresses and makes sounds, but the input is shown on i.e. the bottom bar, while the top bar has the correct note. image

When trying to press A.

The midi file: https://drive.google.com/file/d/1qlgSrNWzhs2c7Sb5ixmzM-bBL_YgRNH2/view?usp=sharing

Device: Processor Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz 2.20 GHz Installed RAM 16.0 GB (15.8 GB usable) System type 64-bit operating system, x64-based processor Pen and touch No pen or touch input is available for this display

OS: Edition Windows 10 Home Version 20H2 Installed on ‎06/‎05/‎2021 OS build 19042.985 Experience Windows Feature Experience Pack 120.2212.2020.0

louis-barman commented 3 years ago

please can you attach the MIDI file that shows the problem. also what OS are you on?

juliusdeblaaij commented 3 years ago

please can you attach the MIDI file that shows the problem. also what OS are you on?

I have updated my original post, thank you for your quick interest. It has been bothering me for a while.

louis-barman commented 3 years ago

I am having trouble understanding what the problem is that you are referring to. There is a very trivial bug that matches your screenshot that should possibly be fixed. When I first load the song but BEFORE I press play it does display the A in the base clef instead of the treble clef. Is that the issue that you are referring to?

But as soon as I press play in follow you mode then i get the following: pb-follow-mode

and it correctly highlights the A note in the treble clef. It works correctly when I play in follow you mode the octave D's in the left hand and the A in the right hand. Which skill mode are you using PB (follow you, play along etc.)? Also I forgot to ask which version of PB are you using?

For the record I have attached your midi file a zip file encase you link is removed at a later date. Air_On_G_String_for_Violin_and_Piano.zip

juliusdeblaaij commented 3 years ago

I am having trouble understanding what the problem is that you are referring to. There is a very trivial bug that matches your screenshot that should possibly be fixed. When I first load the song but BEFORE I press play it does display the A in the base clef instead of the treble clef. Is that the issue that you are referring to?

But as soon as I press play in follow you mode then i get the following: pb-follow-mode

and it correctly highlights the A note in the treble clef. It works correctly when I play in follow you mode the octave D's in the left hand and the A in the right hand. Which skill mode are you using PB (follow you, play along etc.)? Also I forgot to ask which version of PB are you using?

For the record I have attached your midi file a zip file encase you link is removed at a later date. Air_On_G_String_for_Violin_and_Piano.zip

Hello Louis, I suppose my first example didn't carry the correct meaning. Therefore I tried to play the song and encountered it about half way (I think). image

I hope this shows that it is a quite severe bug, as it stops me from playing (I cannot pass this part).

to answer your question, I am on version 1.0.0 from Github.

louis-barman commented 3 years ago

Ha your screenshot again threw me! As I was thinking, "Ah good he has provided a screenshot of the actual bug" and immediately started playing the piece looking out for a problem at bar 9. Anyway I have found the problem it is in BAR 32 and BAR 45

It is actually not a PB bug as I think PB handles this correctly. If you look carefully at the attached screenshot pb-duplicate_e

you will see that although PB displays three notes to be played at the same time, it is actually only two notes with the circled note (E) is the same note for the left and right hands. If you like me play the left hand part first (the octave Es) then it appears the PB has skipped the note in the right hand. But you have already just played that E note in the left hand. What you are meant to do is to play that E using both your thumbs from each hands together.

I can see that you are better at playing this piece than me as my accuracy bar is quite a bit lower than yours. (Although I was sight reading it for the first time). Also I would recommend that you reduce the percentage speed as you learn the piece.

I hope you are finding PB useful. Where did you get that midi file from as I am considering adding to the classical piano pieces see PossibleBoosterMusic.zip here https://github.com/pianobooster/BoosterPreviews/releases/tag/1.0.1-METRONOME1

I shall keep this thread open for a few weeks of before closing it (unless there is another problem)

juliusdeblaaij commented 3 years ago

Ha your screenshot again threw me! As I was thinking, "Ah good he has provided a screenshot of the actual bug" and immediately started playing the piece looking out for a problem at bar 9. Anyway I have found the problem it is in BAR 32 and BAR 45

It is actually not a PB bug as I think PB handles this correctly. If you look carefully at the attached screenshot pb-duplicate_e

you will see that although PB displays three notes to be played at the same time, it is actually only two notes with the circled note (E) is the same note for the left and right hands. If you like me play the left hand part first (the octave Es) then it appears the PB has skipped the note in the right hand. But you have already just played that E note in the left hand. What you are meant to do is to play that E using both your thumbs from each hands together.

I can see that you are better at playing this piece than me as my accuracy bar is quite a bit lower than yours. (Although I was sight reading it for the first time). Also I would recommend that you reduce the percentage speed as you learn the piece.

I hope you are finding PB useful. Where did you get that midi file from as I am considering adding to the classical piano pieces see PossibleBoosterMusic.zip here https://github.com/pianobooster/BoosterPreviews/releases/tag/1.0.1-METRONOME1

I shall keep this thread open for a few weeks of before closing it (unless there is another problem)

Hi Louis, I just noticed that my screenshot was wrong. Assume that I press the B keys, but they are an octave too high on the screen. So I cannot continue the song.

louis-barman commented 3 years ago

Ok please give the give the exact bar number (as displayed by PB) and the beat number and the note name of where the problem is.

Assume that I press the B keys, but they are an octave too high on the screen.

Which bar and beat number are you talking about. I have played the whole thing through (all 47 Bars) and did not find any problem (I take it you are not talking about bar 32 beat 3 the 'E' note duplicated in both hands and bar 45 beat 1 the 'G' note duplicated in both hands referred to in my post above.)

Please note I am unavailable all day tomorrow.