search

piazzai / cvless

Jekyll theme for a beautiful online CV
https://piazzai.github.io/cvless/
MIT License
106 stars 150 forks source link

fix _config.yml #11

Closed Killjoybr closed 1 year ago

Killjoybr commented 1 year ago

I was trying to use the docker image and when I dropped to run locally I've realized that the issue was within the tabbing before name and email. This causes syntax error whilst trying to run the command: 

bundle exec jekyll serve

or when trying to run the provided docker image

docker run -p 4000:4000 -v $(pwd):/site bretfisher/jekyll-serve
piazzai commented 1 year ago

Hi. I understand the issue, but the solution breaks references to the site.author.name and site.author.email variables. When the tabs before name and email are removed, these are no longer recognized as properties of author.

There are three references in the website that end up broken. One is in footer.html, and this could be easily fixed, but two more are in atom.xml and this file is automatically generated by the jekyll-feed plugin. They can't be fixed if not by removing the plugin.

Is there an alternative to removing the tabbing?

Killjoybr commented 1 year ago

I've cloned the project again, now it worked without removing the tabbing. Maybe I haven't configured my Jekyll properly the first time, I tried using the Docker image to check it again but now I'm getting a unauthorized error.

I believe it was not a bug on the project but rather in my local config or prerequisites to build the project with Jekyll. Now I'm cloning the project and its running fine.

The other option was that maybe was one of the plugins had bugs since the Docker image also had a syntax error.

Either way, thanks for replying to my pull request and for providing the beautiful and well crafted template. I wanted to contribute to it somehow, but it seems that the issue wasn't in the code.

piazzai commented 1 year ago

No problem. Thank you for letting me know of the issue. If you see room for improvement anywhere else, feel free to open a new pull request. All contributions are welcome!