search

picardy / angular-fontawesome

A simple Angular directive for FontAwesome
http://picardy.github.io/angular-fontawesome/demo/
MIT License
120 stars 19 forks source link

Removing the Accessibility Wrapper #18

Closed IdanCo closed 9 years ago

IdanCo commented 9 years ago

Remove the wrapper, and add the aria-hidden attribute directly to the icon element

IdanCo commented 9 years ago

Apparently you're early suspicion was right. The wrapper item was redundent, as was discussed here - https://github.com/FortAwesome/Font-Awesome/issues/6133#issuecomment-142979381

My tests confirms this, as well as articles here and here

fastfrwrd commented 9 years ago

Fantastic, truly appreciate the vigilance. Glad we're up to best practices!