pichillilorenzo / flutter_inappwebview

A Flutter plugin that allows you to add an inline webview, to use a headless webview, and to open an in-app browser window.
https://inappwebview.dev
Apache License 2.0
3.21k stars 1.57k forks source link

height calculation issue (rerender more than one time in scrolling) especially in ios #2256

Open 7ooda99 opened 1 month ago

7ooda99 commented 1 month ago

Environment

Technology Version
Flutter version 3.24.0
Plugin version 6.0.0
Android version --
iOS version 17.5
macOS version --
Xcode version --
Google Chrome version --

Device information:

Description

i am rendering multi 'in app web view' in a list view but when i am trying to move to a specific item the height changes so the 
 scrolling missed the correct item particularly in the ios 

Expected behavior: i should scroll to the specific item correctly Current behavior: if i give it item 5 the scroll goes to 9 for example , there is an issue in the height rendering i guess

Steps to reproduce

  1. This
  2. onWebViewCreated: (controller) async { // rootScaffoldKey.currentContext?.read().addWebControllers(widget.pageId, controller);

          controller.addJavaScriptHandler(
              handlerName: "newHeight",
              callback: (List<dynamic> arguments) async {
                int? height = arguments.isNotEmpty ? arguments[0] : await controller.getContentHeight();
                if (mounted) setState(() => pageHeight = height!.toDouble());
              });
          final pageID = widget.pageId;
          final doc = jsonEncode(html);
    
          print("docdoc : $doc");
          final highlights = widget.highlights ?? [];
          pageHighlights = highlights;
          final stringifiedHighlights = highlights.map((e) => jsonEncode(e)).toList();
    
          print("build 11111 : $stringifiedHighlights" );
          webViewController = controller;
          // headlessInAppView = null;
          await webViewController?.evaluateJavascript(source: highlightScript(stringifiedHighlights,pageID,doc));
    
          print("onWebViewCreated");
    
          // getMarkTagPosition(webViewController);
    
        },
  3. Than that
  4. onLoadStop: (controller, url) async { print("onLoadStop"); final searchCubit = context.read();

          // await webViewController?.evaluateJavascript(source: highlightScript);
          // await webViewController?.evaluateJavascript(source: getMarkPositionScript);
          await onSelectionChanged(context);
          await onSelectHighlight(context);
          Future.delayed(Duration(milliseconds: 500), () async {
            if(searchCubit.searchResult.isNotEmpty && searchCubit.searchResult[searchCubit.state.resultCurrentIndex].pageId == widget.pageId) {
              final currentSearch = searchCubit.searchResult[searchCubit.state.resultCurrentIndex];
              await webViewController?.evaluateJavascript(
                  source: searchText(currentSearch.startOffset, currentSearch.endOffset));
            }
          },);
    
        },
  5. Then
  6. onPageCommitVisible: (controller, url) async {

          final pageID = widget.pageId;
          final doc = jsonEncode(html);
    
          print("docdoc : $doc");
          final highlights = widget.highlights ?? [];
          pageHighlights = highlights;
          final stringifiedHighlights = highlights.map((e) => jsonEncode(e)).toList();
    
          print("build 11111 : $stringifiedHighlights" );
          // await webViewController?.evaluateJavascript(source: jsCode);
    
          // print("onPageCommitVisible");
          await webViewController?.evaluateJavascript(source: highlightScript(stringifiedHighlights,pageID,doc));
          Future.delayed(Duration(milliseconds: 300),() async =>               await webViewController?.evaluateJavascript(source: getMarkPositionScript)
            ,);
    
        },
github-actions[bot] commented 1 month ago

👋 @7ooda99

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!