Add FilterTags feature - Githubissues

picklesdoc / pickles

The open source living documentation generator

http://www.picklesdoc.com/

Apache License 2.0

464 stars 164 forks source link

Add FilterTags feature #564

Closed spacehole1 closed 4 years ago

spacehole1 commented 6 years ago

Hello,

My Proposition for issue #527 I still need to add several Unit test to check : feature generated with all or only filtered elements

Regards,

dirkrombauts commented 6 years ago

Thanks for your contribution. I haven't looked at in detail yet, because I got stuck at the name "FilterTags". To me, "filter" sounds like "filter out" - and the tag actually does the opposite thing. How about something like "IncludeOnlyTags"?

dirkrombauts commented 6 years ago

So far so good ... but there's a conflict (your other changes to the MSBuild.targets file) and I see no changes to the .xaml file for the GUI. Could you add those please? Then we're good to go.

spacehole1 commented 6 years ago

Good idea. I changed my code to take your remark in account

spacehole1 commented 6 years ago

Thanks for the remark, I always miss the UserInterface..

dirkrombauts commented 6 years ago

Cool, thanks!

I noticed another thing that's missing: there are no unit tests ... could you please add some?

flubbid commented 4 years ago

Was this ever implemented?

dirkrombauts commented 4 years ago

Hi,

Thank you for your contribution, and the time you put into this.

Unfortunately, the feature does not work as advertised. I found two problems:

separating multiple tags by semicolon does not work
A directory that included no scenarios or features that were tagged to be included, was included anyway as an empty directory.

I'm in the process of ending my involvement in Pickles. I don't have the time or energy to investigate these issues, so I'm closing the pull request and will not include it.

Thanks again for the time you put into this.