picodotdev / alis

Arch Linux Install Script (or alis, also known as the Arch Linux executable installation guide and wiki) installs an unattended, automated and customized Arch Linux system.
https://picodotdev.github.io/alis/
GNU General Public License v3.0
823 stars 319 forks source link

Small changes to the code #236

Closed mfgbhatti closed 1 year ago

mfgbhatti commented 1 year ago

Hi there, I been going through the code, there are some changes I want to propose.

mfgbhatti commented 1 year ago

The following code is used in refind, systemd and efistub bootloaders

local KERNEL="$1"
local MICROCODE=""

if [ -n "$INITRD_MICROCODE" ]; then
    local MICROCODE="initrd=/$INITRD_MICROCODE"
fi

I will be great if we can concise it to a function

picodotdev commented 1 year ago

Thanks for the PR! I did some changes in the code review but I merged them in a quite similar form.

mfgbhatti commented 1 year ago

You are welcome!