picodotdev / alis

Arch Linux Install Script (or alis, also known as the Arch Linux executable installation guide and wiki) installs an unattended, automated and customized Arch Linux system.
https://picodotdev.github.io/alis/
GNU General Public License v3.0
823 stars 319 forks source link

copy_logs fails if any password contains slashes #253

Open pjones opened 8 months ago

pjones commented 8 months ago

If any of the password variables (LUKS_PASSWORD, ROOT_PASSWORD, or USER_PASSWORD) contains a slash it will break the sed replacement and the alis.sh script will fail with an error.

Also, the copy_logs function contains a lot of redundancy. The body of the function could easily be wrapped in a loop.

Thank you for this project. It saved me a lot of time today. I wish I had time to submit a patch but I don't currently have any free time. If this is still open in a few weeks I will try to come back around and solve it.