search

pierrepo / PBxplore

A suite of tools to explore protein structures with Protein Blocks :snake:
https://pbxplore.readthedocs.org/en/latest/
MIT License
28 stars 17 forks source link

compatibility check for weblogo versions #134

Closed HubLot closed 7 years ago

HubLot commented 7 years ago

Fix issue #133.

In the last version of Weblogo (3.5), the API has changed. The color class ColorGroup is now SymbolColor but not the prototype. In order to support different version of weblogo, I add a compatibility check, similar to range Python2/3, to ensure it will work for all versions.

The other solution is to keep only SymbolGroup and to add in the documentation we only support Weblogo version >=3.5

pierrepo commented 7 years ago

Indeed, that's weird they change from ColorGroup to SymbolColor. Since, PBxplore is not totally released (yet). I would suggest we do not keep the backward compatibility and ask weblogo version to be >= 3.5

jbarnoud commented 7 years ago

Keeping the backward compatibility indeed increases the complexity, but I recently grew awfully aware of how out of date people can be. Also, it may be easier to install and integrates in ones work flow if there is no need to update an already there weblogo. Most of all, the PR is already there.

Al of this rumble to say that I would vote to keep the backward compatibility as it is rather cheap to do.

pierrepo commented 7 years ago

OK. Fair enough.

HubLot commented 7 years ago

Plus, just for information, the conda package for Weblogo is still in 3.4 version (https://anaconda.org/bioconda/python-weblogo)...