Make KV Value optional - Githubissues

pierresouchay / consul-rust

Rust client libray for Consul HTTP API

Apache License 2.0

92 stars 48 forks source link

Open fussybeaver opened 4 years ago

fussybeaver commented 4 years ago

The previous PR got conflated with other work that we were doing, so I've re-opened with the original fix for #24 and added a mockito test.

pierresouchay commented 3 years ago

Hello @fussybeaver ,

Sorry for the huge delay in reviewing this. Are you still interested in fixing it?

You are right, the value might be null, but more globally, the API is probably wrong regarding its semantics.

The big downside is that it will force us to create a breaking change, requiring us to bump the minor.

Please provide a rebase and I'll be glad to integrate it.

Regards

fussybeaver commented 3 years ago

Hi @pierresouchay , thanks for picking this up again..