search

pigoz / mplayerosx-builds

build scripts of mplayer2 for Mac OSX
35 stars 8 forks source link

Window of generated mpBinaries in Mplayer OSX Extended isn't behaving correctly #15

Open gerjomarty opened 11 years ago

gerjomarty commented 11 years ago

When I've built the code previously (a few months ago), and with the built-in mplayer binary in MPlayer OSX Extended, when opening a video, the video opens in the actual MPlayer OSX Extended window... See image ...and moving forward and backward in the playlist keeps the window position and maximised state.

When I tapped your mplayer2 Homebrew keg and compiling that, then again made an mpBinaries file for that mplayer2, the window behaviour seems to have changed. mplayer now seems to open in its own window entirely, outside the MPlayer OSX Extended window... See image ...and when moving between files in the playlist, this extra window closes and reopens for the new file, not remembering the window position or maximised state of the previous one.

This is pretty annoying when watching a playlist of files on a secondary monitor, as each new file will open on the wrong screen and would need to be positioned again.

I tried having a look around the code, but I'm not particularly sure where this behaviour is happening (i.e. whether the problem is here, or in mplayer2, though I suspect it's the latter). Sorry.

pigoz commented 11 years ago

Hello, this is a known issue. MPlayerOSX Extended hardcodes the video output used and in mplayer2 I changed the name from corevideo to sharedbuffer. I did this change to mplayer2 in order to simplify the code and to make the performance better.

Unfortunately Adrian went missing to this was never dealt with in the MPlayerosx Extended codebase. This should work if you compile a new version of MPlayerOSX Extended and on line:

https://github.com/sttz/MPlayer-OSX-Extended/blob/master/source/core/MPlayerInterface.m#L417

change corevideo: to sharedbuffer:.

Keep in mind that I advise against using sharedbuffer as the picture quality is not as good to stuff like gl or gl3. You can add --xineramascreen=<screen_id> and --fs to the options to always open the window in a different screen and in fullscreen.

Btw, right now I'm using https://github.com/mpv-player/homebrew-mpv as I think the user experience is better than the GUIs. For people who want a GUI I'm starting to point them to VLC as it's grown better than the mplayer OSX GUIs.

Let me know if you need further help or if your problem is solved.