pik-piam / sodym

MIT License
0 stars 2 forks source link

Make current MFASystem __init__ a class method from_reader_and_definition (name tbd), and have an init to which we directly pass dims, flows, parameters, etc. #24

Closed JakobBD closed 2 months ago

JakobBD commented 3 months ago

In my view it would add flexibility and, more importantly, transparency (pydantic auto-doc of the attributes of MFASystem). Would go nicely hand-in-hand with passing separate readers to init Dimensions and Parameters...

Since you decided against it, what where your reasons?