search

pik-piam / sodym

MIT License
0 stars 2 forks source link

Let data writer distinguish between m and g as product dimensions #41

Closed Merjo closed 1 month ago

Merjo commented 1 month ago

Thank you - I was thinking as well that a refactoring would be good, right now the sankey diagram just shows the results for the CAZ region in 2050, and it would be good if this could be parameterized in the config or something, ideally with also the option to sum over the regions to get a total world figure. I'm prioritizing other things right now but could propose an implementation if needed as well.

Merjo commented 1 month ago

What is our protocol on merging pull requests after one person has approved them? Can I just go ahead or should we wait for everybody to approve? Just new to Git :)

SallyDa commented 1 month ago

You can go ahead and merge after one approving review. We decided to do it like this for now, and later we can review and see if everyone is happy with this approach.

JakobBD commented 1 month ago

I've added a git page on this, to have a common understanding: https://github.com/pik-piam/sodym/wiki/Git-protocol Feel free to make/propose changes, but inform the others (e.g. on mattermost)