Closed jaredgoldman closed 1 year ago
@jaredgoldman this ready for serious review?
@goodboy I think we're ready for some more testing
@algorandpa seems like i can only stage order with size=0
but other then that historical and live data seems right 🏄🏼
@jaredgoldman as mentioned in chat as well we've got some kinda strange thing going on with trade rate calcs:
yeah so if you look at how we (currently) implement the trade rate, it's basically just counting the number of vlm-containing-trades (aka clears):
my guess is somehow we've got a tick being generated by ur backend code that's fitting into the trade
tick type, without it actually being a trade and thus this count is being triggered?
See https://github.com/pikers/piker/blob/master/piker/fsp/_volume.py#L162 for the filter loop.
hopefully that helps to start digging, if not we can resume in chat 👍🏼
@goodboy merged the binance changes and added anext()
Looking the code in the ol' vim i'm seeing a lot of these brother:
Added patch commit to get things working again after your review changes in #498
@goodboy I refactored the subscribe
and stream_messages
logic to:
ping_task
lol, the earlier implementation was wildy inefficient spawning a diff ws connection and ping task for each symbol. In addition I've addressed the comments for which I'm not waiting on a reply from you (no rush). We're also getting to the point where we should consider factoring this into a few different files, especially before adding order control.
We're also getting to the point where we should consider factoring this into a few different files, especially before adding order control.
yes, if you want to in this PR it's fine by me. currently we something like:
.api
.feed
.broker
@jaredgoldman :boom:
excellent work yet again compadre 🏄🏼
nice follow up issue and final linting before getting this in ma dawg!
This PR includes a brokerd module for Kucoin's api. So far, only code for market data has been implemented. This includes:
Symbol fuzzy search
Remaining tasks for full support are detailed in https://github.com/pikers/piker/issues/499