pikvm / pikvm

Open and inexpensive DIY IP-KVM based on Raspberry Pi
https://pikvm.org
GNU General Public License v3.0
8.31k stars 456 forks source link

Set MSD writable from REST API #1428

Closed bjackman closed 3 days ago

bjackman commented 3 days ago

Is your feature request related to a problem? Please describe.

When it's emulated flash storage the MSD can be writable on read-only. This can be flipped in the UI. But I can't see a documented way to do that via REST.

Describe the solution you'd like

Seems likely this is just a documentation gap. But if not I guess we just need a param like read_only=0 or writable=1.

bjackman commented 3 days ago

Oh - https://github.com/pikvm/kvmd/blob/7394588279129bba8942323867a65bbc950d1396/kvmd/apps/kvmd/api/msd.py#L79

I think it's probably rw=1. Can try this later.

bjackman commented 3 days ago

Even better, I can try it right now. Aand it works.

Raised this issue then figured it out within 3 minutes, maybe I should have just tried to figure it out first :laughing:

mdevaev commented 3 days ago

Thanks!