Algorithm 2 is often buggy

pillargg / pillar_algos

Finds best timestamps to cut at

https://docs.pillar.gg/pillar_algos/

GNU General Public License v3.0

1 stars 0 forks source link

Algorithm 2 is often buggy #21

Closed RusseII closed 3 years ago

RusseII commented 3 years ago

(makes 5 clips with only one minute of chat data)

( only 5 seconds long) https://dev.pillar.gg/videos/981521027

pomkos commented 3 years ago

Weird. I'll take a look today.

pomkos commented 3 years ago

Weird af

pomkos commented 3 years ago

Ya turns out I forgot to take the means of each chunk. So the results actually represent "what time did this unique person start and stop chatting" lmao.

Sidenote: this is why I BEGGED for an algo review with some people

Edit: Im gonna make a mini unit test for each algo

pomkos commented 3 years ago

Closing and pushing.