pimatic / homeduino

Arduino library for home control
GNU General Public License v3.0
47 stars 40 forks source link

Onewire -> Master #15

Open ronaldsteen opened 9 years ago

ronaldsteen commented 9 years ago

Hi,

Along with the other pull requests goes this version of homeduino. Maybe it's good to merge it back to master?

Cheers, Ronald

sweetpi commented 9 years ago

Hi Ronald,

do you use the DST sensors and a 433mhz receiver together? A problem could be that the one-wire library disables global interrupts what probably leads to missing timings in rfcontrol.

As long I'm not sure how to solve this, I think its better to leave it on an separate branch.

ronaldsteen commented 9 years ago

Hi,

I'm not using the sensor along a 433mhz receiver.. I'm not sure about the one-wire library going along with interrupts / rfcontrol. I'm fine with keeping the branches separate.

Should we put a line in the readme of both pimatic-homeduino and homeduino explaining this?

On Fri, Feb 27, 2015 at 5:41 PM sweet pi - sweet home < notifications@github.com> wrote:

Hi Ronald,

do you use the DST sensors and a 433mhz receiver together? A problem could be that the one-wire library disables global interrupts what probably leads to missing timings in rfcontrol.

As long I'm not sure how to solve this, I think its better to leave it on an separate branch.

— Reply to this email directly or view it on GitHub https://github.com/pimatic/homeduino/pull/15#issuecomment-76425724.

ghost commented 9 years ago

I am using the 433mhz receiver and transmitter with the DST version of Ronald. My wireless switches work fine. And as far as i can check it my 433mhz receiver gets the codes from my remotes (checked in debug messages).

sweetpi commented 9 years ago

I've added a notice to the README. I will merge it to master when I find time to test it myself and add options to enable/disable parts of homeduino in the Makefile (see #14 ).

@frosenheimer thanks for the feedback. That sound good. I don't now how high the risk is to miss an interrupt in rfcontrol while the onewire lib disable them.