search

pimbrouwers / Validus

An extensible F# validation library.
Apache License 2.0
144 stars 10 forks source link

Added support for ValueOption #10

Closed xperiandri closed 2 years ago

xperiandri commented 2 years ago

I haven't found tests for required https://github.com/pimbrouwers/Validus/blob/42ad8cefdebf57a6b3ff4c8e642609e771c092d3/src/Validus/Validus.fs#L333 Do they exist?

pimbrouwers commented 2 years ago

Fantastic work, thank you so much! When I am back at home, hopefully this evening, I will review.

It is entirely possible I forgot to add a test for required. Let me check when I get home.

pimbrouwers commented 2 years ago

I've trimmed all the extraneous whitespace from the master (I had no clue that setting was disabled on my personal computer, so stupid).

Can you do a git pull from master to sync in all of those changes, then well merge this in.

Can you write the tests for required?

xperiandri commented 2 years ago

It is better if you make that, because I'm not good at it

pimbrouwers commented 2 years ago

Will do! No problem at all. I appreciate your time and energy on this very very much <3