pimcore / customer-data-framework

Customer Data Framework community bundle adds capability for management of customer data to Pimcore.
https://pimcore.com/docs/platform/Customer_Management_Framework/
Other
81 stars 93 forks source link

Explicitly require pcntl #508

Closed NiklasBr closed 11 months ago

NiklasBr commented 1 year ago

Issue discovered after upgrading to PHP 8.2 and Pimcore 11.

[2023-10-16T17:55:07.861905+02:00] php.CRITICAL: Uncaught Error: Undefined constant "SIGTERM" {"exception":"[object] (Error(code: 0): Undefined constant \"SIGTERM\""} []

It is used here:

https://github.com/pimcore/customer-data-framework/blob/9e6c392f8fcb6cb41aff4d833a500fce631de36b/src/SegmentManager/SegmentBuilderExecutor/DefaultSegmentBuilderExecutor.php#L230-L232

And is installed in the default Docker files here:

https://github.com/pimcore/docker/blob/0c1adac7df7687469f2334d55bf0fe9405b64a71/Dockerfile#L32-L44

So it may not be too much of a blocker, but it should be made clear for those of us who have our own Dockerfiles.