search

pimcore / demo

The Official Pimcore Demo Package - You're new to Pimcore? That's your entry point! 🤓
Other
100 stars 106 forks source link

Upgrade guzzle6-adapter to v2 so CoreShop can be installed for a all-in one demo. #166

Closed Yivan closed 4 years ago

Yivan commented 4 years ago

Hello,

We are trying to put a global demo of Pimcore (aka this demo repository) with some main/famous extensions. We manage to add formbuilder, but there is an incompatibility with coreshop because of dependencies.

Please see the guzzle6-adapter: https://github.com/pimcore/demo/blob/master/composer.json#L14 https://github.com/coreshop/CoreShop/blob/master/composer.json#L91

Could the demo requirements be changed to v2 of guzzle6-adapter so demo of coreshop could be installed along side ?

Purpose is to be able to show the power of Pimcore along an unique Pimcore instance for showcases (and showing that native ecommerce can work alongside coreshop and vice-versa).

Thanks.

(an issue has been opened on Coreshop side: https://github.com/coreshop/CoreShop/issues/1206)

fashxp commented 4 years ago

well tested PRs are welcome.

Yivan commented 4 years ago

@fashxp @dpfaffenbauer It seems this issue has been resolved as guzzle6-adapter has been moved to v2. Please see this commit: https://github.com/pimcore/demo/commit/e9e4208ab2be4236c60bf25dcbfdaad94145ad99#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780

I was thinking it asked more changes !

I will try now to install pimcore ecommerce and coreshop together and will report here the result.

Yivan commented 4 years ago

Hum, there is another dependencies problem : (

Using version ^2.1 for coreshop/core-shop
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - coreshop/core-shop 2.1.0 requires dachcom-digital/emailizr ^1.0.6 -> satisfiable by dachcom-digital/emailizr[v1.0.6, v1.1.0].
    - coreshop/core-shop 2.1.1 requires dachcom-digital/emailizr ^1.0.6 -> satisfiable by dachcom-digital/emailizr[v1.0.6, v1.1.0].
    - dachcom-digital/emailizr v1.0.6 requires pelago/emogrifier ^2.0.0 -> satisfiable by pelago/emogrifier[v2.0.0, v2.1.0, v2.1.1, v2.2.0].
    - dachcom-digital/emailizr v1.1.0 requires pelago/emogrifier ^2.0.0 -> satisfiable by pelago/emogrifier[v2.0.0, v2.1.0, v2.1.1, v2.2.0].
    - pelago/emogrifier v2.2.0 requires php ^5.5.0 || ~7.0.0 || ~7.1.0 || ~7.2.0 || ~7.3.0 -> your PHP version (7.4.2) does not satisfy that requirement.
    - pelago/emogrifier v2.1.1 requires php ^5.5.0 || ~7.0.0 || ~7.1.0 || ~7.2.0 || ~7.3.0 -> your PHP version (7.4.2) does not satisfy that requirement.
    - pelago/emogrifier v2.1.0 requires php ^5.5.0 || ~7.0.0 || ~7.1.0 || ~7.2.0 || ~7.3.0 -> your PHP version (7.4.2) does not satisfy that requirement.
    - pelago/emogrifier v2.0.0 requires php ^5.5.0 || ~7.0.0 || ~7.1.0 || ~7.2.0 -> your PHP version (7.4.2) does not satisfy that requirement.
    - Installation request for coreshop/core-shop ^2.1 -> satisfiable by coreshop/core-shop[2.1.0, 2.1.1].

Installation failed, reverting ./composer.json to its original content.

The problem seems to come from dachcom-digital/emailizr which need pelago/emogrifier which is not compatible with 7.4.2. It means coreshop isn't compatible with php 7.4... strange i was thinking it was.

@dpfaffenbauer @solverat Should I open an issue on coreshop side or emailizr side ? It would be very nice to be able to use CoreShop with PHP 7.4 and some native ecommerce feature in the same time.

I can run again a test as soon some fix are done.

Thanks.

dpfaffenbauer commented 4 years ago

@Yivan please check if there might be already a PR or something to solve it before pinging us: https://github.com/dachcom-digital/pimcore-emailizr/pull/17

Yivan commented 4 years ago

Just for information, this result was obtained by installing fresh Pimcore demo and after running:

# Formbuilder
composer require dachcom-digital/formbuilder
php bin/console pimcore:bundle:enable FormBuilderBundle
php bin/console pimcore:bundle:install FormBuilderBundle

# Coreshop
composer require coreshop/core-shop
php bin/console pimcore:bundle:enable CoreShopCoreBundle
php bin/console coreshop:install
php bin/console coreshop:install:demo

Form builder install ok, but CoreShop has the dependencies problem I mentioned.

Yivan commented 4 years ago

@dpfaffenbauer You are right this merge request could resolve this. Sorry for pinging without having looked into it. I will wait the merge request is done and is released to test again. Thanks.

fashxp commented 4 years ago

not issue of this demo-package -> closed