search

pimcore / demo

The Official Pimcore Demo Package - You're new to Pimcore? That's your entry point! 🤓
Other
97 stars 106 forks source link

[Improvement]: mailpit container_name docker-compose.yaml #587

Closed derhecht closed 2 weeks ago

derhecht commented 3 weeks ago

Improvement description

Every container which is starting up by docker compose command will generate a custom name based on folder/project name. Expect the mailpit container. This will conflict e.g. if you running multiple instances of pimcore on one machine or have an already standalone instance of mailpit running.

Improvement: Remove container_name directive from docker-compose.yaml file.

The mailpit service is referenced by its service name which is mailpit - for every setup - not by its container name.

blankse commented 3 weeks ago

@derhecht I created a PR: https://github.com/pimcore/demo/pull/589

alexz707 commented 2 weeks ago

Thanks for bringing that up and thanks for the PR, already merged