search

pimcore / ecommerce-framework-bundle

Ecommerce Framework community bundle provides e-commerce functionality such as product listing and filtering, pricing, carts and checkouts for Pimcore.
https://pimcore.com/docs/platform/Ecommerce_Framework/
Other
11 stars 33 forks source link

[Ecommerce][Bug] Empty mandatory fields does not prevent saving #99

Closed NiklasBr closed 1 year ago

NiklasBr commented 5 years ago

Bug Report

### Expected behavior Saving a Price Rule condition should not be possible when *mandatory* fields are empty. ### Actual behavior Saving works, no error messages or indications. ### Steps to reproduce Create a Price Rule condition with a mandatory field. Save it. ### Code example If this field is left empty, the condition should not be saved, preferably an error message should be displayed. ```js { xtype: "numberfield", fieldLabel: "Minimum quantity", labelWidth: 200, mandatory: true, name: "qty", maxValue: 100000, value: data.qty, width: 600, } ```
kingjia90 commented 1 year ago

Thank you for reporting and for your patience! Do you have any chance to try this PR https://github.com/pimcore/ecommerce-framework-bundle/pull/123?