search

pimcore / web-to-print-bundle

Web-to-Print community bundle adds web-to-print features to Pimcore documents.
https://pimcore.com/docs/platform/Web_To_Print/
Other
4 stars 12 forks source link

[Task]: Fix experimental test against 11.x-dev #84

Closed kingjia90 closed 2 months ago

blankse commented 2 months ago

https://github.com/pimcore/demo/pull/578#discussion_r1662473323

You could also add a branch alias for pimcore/pimcore, like https://github.com/pimcore/admin-ui-classic-bundle/pull/594

Then you can remove the "as 11.0.0" and the test will know the right version.

blankse commented 2 months ago

@kingjia90 I created the PR for the branch alias: https://github.com/pimcore/pimcore/pull/17403 When this is merged you could use 11.x-dev without as 11.0.0

blankse commented 2 months ago

Why are the admin-ui-classic-bundle versions 1.5.0 and 1.5.1 not allowed with Pimcore 11.4? (Requires ~11.3.0)

In this case, you also need the admin-ui-classic-bundle version 1.x to work. It requires ^11.3.0.

brusch commented 2 months ago

@kingjia90 why not just use 

  "prefer-stable": true,
  "minimum-stability": "dev",

as we do in other bundles? Should work, right?

See: https://github.com/pimcore/copilot-bundle/blob/1.x/composer.json#L15

blankse commented 2 months ago

@brusch I think this doesn't work with the requirements. The composer doesn't know exactly which version 11.x is. The admin-ui-classic-bundle requires ^11.3. At the moment, all tests will be updated to 11.3.99. However, I think it is easy to set one branch alias, so there is only one location to change it.

For example: https://github.com/pimcore/demo/pull/578 But there were more changes to test workflows if I remember correctly

kingjia90 commented 2 months ago

iirc there was also a limitation due to the composer conflict not working well with the unreleased packages

brusch commented 2 months ago

But 11.x-dev should be covered by ^11.3 right?

kingjia90 commented 2 months ago

Mhh, i recall we had the stability dev and got removed at some point https://github.com/pimcore/web-to-print-bundle/pull/46/commits/aa6d269ebb98239dec2c7c715e950f15a9a05710 (https://github.com/pimcore/web-to-print-bundle/pull/46) but i don't remember the reason anymore 😅 Let's see with https://github.com/pimcore/web-to-print-bundle/pull/85 if it re-occurs and/or fixes the issue

blankse commented 2 months ago

But 11.x-dev should be covered by ^11.3 right?

I don't know. We always set branch aliases for .x branches. But when this is the case, why do you set an inline alias in all test workflows?

The current problem is that the admin-classic-ui-bundle has the requirement ~11.3.0 in the latest releases. This is also not covered. But the branch alias is now 11.4.x-dev. This is also not covered.

For conflicts, I think a more precise version is also needed.

brusch commented 2 months ago

@blankse agree - when using the tilde ~11.3.0 then 11.x-dev is not covered, but we have that for the admin-ui-classic-bundle. So I'm afraid we need the branch alias for that. @kingjia90 but for all the other bundles I'd keep the "minimum-stability": "dev", approach.