Bugfix for Issue #22 https://github.com/pimoroni/st7735-python/issues/22

lynniemagoo commented 2 years ago

**Describe the scope of your change--Bugfix for Issue #22 where red and blue pixels reversed when displayed with invert=false or invert=true. See full comments in the code.
Describe any known limitations with your change. Needs to be reviewed/regression tested with Pimoroni display (I used Adafruit ST7735R with Green tab on screen protector)

Gadgetoid commented 2 years ago

See replies to #22

Also- no need to bump the version number, I'll do that as part of preparing the next release.

lynniemagoo commented 2 years ago

Give me through the weekend to review pdf and to retest. Then we can delete the PR and I will kill my fork and recreate. Will you be adding the new property? So to use with my display I will have to use invert=False,bgr=True. These are the opposite of the defaults.

Thanks so much.

Sent from my iPhone

On Mar 17, 2022, at 5:33 AM, Philip Howard @.***> wrote:

See replies to #22

Also- no need to bump the version number, I'll do that as part of preparing the next release.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

lynniemagoo commented 2 years ago

I put comments in the original issue. Please review if you have time.

pimoroni / st7735-python

Bugfix for Issue #22 https://github.com/pimoroni/st7735-python/issues/22 #23