pinballmap / pbm-react

PBM React Native: iOS & Android Apps
https://pinballmap.com/app
GNU General Public License v3.0
33 stars 9 forks source link

If "contact" link is clicked from "edit location info" screen, pass in the location name #550

Closed RyanTG closed 3 months ago

RyanTG commented 4 months ago

We really often get contact messages where people don't state what location they're talking about. After asking a few people, it's because they all assume the app knows what location they were looking at prior to that.

It's clear that people are not going to manually type in the location name - most are not reading our fine print asking them to do so.

Thinking about possible solutions:

bpoore commented 4 months ago

How do you view the messages coming in from contact us? We can append to the message the location name. Would adding a couple new lines before the location at the end make sense? Or would you rather no new line chars? If you want it as a different attribute of the request body, we can do that too, but might require work on the API end to consume it.

{"email": "", "lat": 45.46765555629063, "lon": -122.75617979418726, "message": "Test with location 

 The Old Market Pub & Brewery", "name": "", "user_email": "email", "user_token": "token"}
RyanTG commented 4 months ago

How do you view the messages coming in from contact us?

Via email, usually. From this mailer: https://github.com/pinballmap/pbm/blob/master/app/views/admin_mailer/send_admin_notification.html.haml

Which contains user.username, user.email, and message fields (if user is logged in).

Appended to the message is totally fine. And new lines are totally fine (assuming they are correctly consumed by the mailer - but if not, we can tweak).

bpoore commented 4 months ago

With how string interpolation is occurring via the mailer, we are not currently getting the new line characters (I tried a few ways to see if we could get new lines in there, but no dice). Would you rather we add a new attribute for the mailer to have a new field or would just including the location name at the end of the message be sufficient? We can add more characters or whatever will make this easiest to consume for you if we go the route of just adding to the end of the message.

Screenshot 2024-05-06 at 12 34 01 PM
bpoore commented 4 months ago

commit