search

pingcap / parser

A MySQL Compatible SQL Parser
Apache License 2.0
1.41k stars 489 forks source link

ci: remove github action on pull request #1341

Closed purelind closed 3 years ago

purelind commented 3 years ago

What problem does this PR solve?

remove github action on pull request, jenkins verify ci will run on every pr

What is changed and how it works?

Check List

Tests

Related changes

ti-chi-bot commented 3 years ago

[REVIEW NOTIFICATION]

This pull request has been approved by:

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment. After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review. Reviewer can cancel approval by submitting a request changes review.
purelind commented 3 years ago

cc @zhouqiang-cl

purelind commented 3 years ago

I think you can just remove the github actions file.

jenkins-parser/verify only runs on pull request

tisonkun commented 3 years ago

I think you can just remove the github actions file.

jenkins-parser/verify only runs on pull request

Hmmm...Then things go really weird that we are in an intermediate stage. Any plan to run this set of test on commits without GitHub Actions? Or we just make sure PR passed and thus commits?

purelind commented 3 years ago

I think you can just remove the github actions file.

jenkins-parser/verify only runs on pull request

Hmmm...Then things go really weird that we are in an intermediate stage. Any plan to run this set of test on commits without GitHub Actions? Or we just make sure PR passed and thus commits?

Done! Now github action on branch master has been removed

tisonkun commented 3 years ago

/cc @tangenta

tangenta commented 3 years ago

/merge

ti-chi-bot commented 3 years ago

This pull request has been accepted and is ready to merge.

Commit hash: 14a67a81b3c10131854930a9aee17619d5534bd4

tisonkun commented 3 years ago

@purelind if you turn on verify ci on all branches, could you please cherry pick this PR to all those branches?