backend: import planner/core package to initialize expression.RewriteAstExpr - Githubissues

pingcap / tidb-lightning

This repository has been moved to https://github.com/pingcap/br

Apache License 2.0

142 stars 66 forks source link

backend: import planner/core package to initialize expression.RewriteAstExpr #526

Closed xuhui-lu closed 3 years ago

xuhui-lu commented 3 years ago

What problem does this PR solve?

close https://github.com/pingcap/tidb/issues/21342 planner/core and expression package need to be imported together to initialized expression.RewriteAstExpr

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to update the tidb-ansible repository
Need to be included in the release note

CLAassistant commented 3 years ago

All committers have signed the CLA.

lance6716 commented 3 years ago

/run-all-tests

lance6716 commented 3 years ago

I think this is an acceptable change, WDYT @glorv and we might upgrade tidb dependency after https://github.com/pingcap/tidb/issues/21342

cc @XuHuaiyu

lance6716 commented 3 years ago

LGTM

lance6716 commented 3 years ago

Hi, we added this import in https://github.com/pingcap/tidb-lightning/blob/56bc32daad19b9dff10104c55300292de959fde3/lightning/restore/restore.go#L53-L54 but of course this PR found a better place. Could you remove above import or close that issue directly?

lance6716 commented 3 years ago

PTAL @glorv

XuHuaiyu commented 3 years ago

@xuhui-lu Friendly ping, a comment needs to be addressed

xuhui-lu commented 3 years ago

@xuhui-lu Friendly ping, a comment needs to be addressed

thanks for reminder!