UCP: use shellcheck to verify our shell scripts - Githubissues

pingcap / tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.

https://docs.pingcap.com/tidb-in-kubernetes/

Apache License 2.0

1.22k stars 489 forks source link

UCP: use shellcheck to verify our shell scripts #1561

Open cofyc opened 4 years ago

cofyc commented 4 years ago

Feature Request

Is your feature request related to a problem? Please describe:

avoid potential issues in our scripts and make them uniform.

Describe the feature you'd like:

add a verify script to check and print issues in our shell scripts with shellcheck, e.g. https://github.com/kubernetes/kubernetes/blob/v1.17.1/hack/verify-shellcheck.sh

shellcheck is a widely used script analysis tool.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

https://www.shellcheck.net/

Score

200

Mentor(s)

@cofyc

Contact the mentors: #tidb-challenge-program channel in TiDB-Operator Community Slack Workspace

Recommended Skills

shell
Golang
Kubernetes

github-actions[bot] commented 4 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days