fix lpad/rpad trailing zero miss (#9610)

pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial

https://docs.pingcap.com/tidb/stable/tiflash-overview

Apache License 2.0

950 stars 410 forks source link

fix lpad/rpad trailing zero miss (#9610) #9633

Closed ti-chi-bot closed 1 week ago

ti-chi-bot commented 1 week ago

This is an automated cherry-pick of #9610

What problem does this PR solve?

Issue Number: close #9465

Problem Summary:

What is changed and how it works?

Check List

Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

fix lpad/rpad trailing zero miss

ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/release-8.5/OWNERS)~~ [windtalker,yibin87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline:

2024-11-18 07:16:03.989212122 +0000 UTC m=+858926.180081104: :ballot_box_with_check: agreed by yibin87.
2024-11-18 07:17:40.895607838 +0000 UTC m=+859023.086476835: :ballot_box_with_check: agreed by windtalker.

ti-chi-bot[bot] commented 1 week ago

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

guo-shaoge commented 1 week ago

/retest