pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
950 stars 410 forks source link

Abort uploading checkpoint if s3 lock client is not initialized (#9655) #9659

Closed ti-chi-bot closed 1 week ago

ti-chi-bot commented 1 week ago

This is an automated cherry-pick of #9655

What problem does this PR solve?

Issue Number: close #9394

Problem Summary:

there is a time gap after TMTContext is created but before TMTContext::initS3GCManager finished

What is changed and how it works?

Do not init S3LocalLockManager, if the client is not set.

Check List

Tests

Side effects

Documentation

Release note

None
ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/release-8.5/OWNERS)~~ [CalvinNeo,JaySon-Huang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: