pingcap / tiflash

The analytical engine for TiDB and TiDB Cloud. Try free: https://tidbcloud.com/free-trial
https://docs.pingcap.com/tidb/stable/tiflash-overview
Apache License 2.0
950 stars 410 forks source link

Storages: enhance data sharing column cache #9661

Closed Lloyd-Pottiger closed 2 days ago

Lloyd-Pottiger commented 1 week ago

What problem does this PR solve?

Issue Number: close #6092

Problem Summary:

Using ColumnCache whose cache entry is a pack. ColumnSharingCache's cache entry is several packs.

What is changed and how it works?

Check List

Tests

Side effects

Documentation

Release note

None
JaySon-Huang commented 2 days ago

Remove the duplicate code of getting data type on disk in different places: https://github.com/Lloyd-Pottiger/tiflash/pull/19

ti-chi-bot[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiflash/blob/master/OWNERS)~~ [JaySon-Huang,JinheLin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 days ago

[LGTM Timeline notifier]

Timeline: